Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Defensive Code #1586

Merged
merged 1 commit into from
Apr 16, 2019
Merged

fix: Defensive Code #1586

merged 1 commit into from
Apr 16, 2019

Conversation

Crash--
Copy link
Contributor

@Crash-- Crash-- commented Apr 16, 2019

There is an underlying bug, but this is a quick fix.

React was bugged at some point, but it seems that was fixed long time ago (facebook/react#5719)

@cozy-bot
Copy link

Visual Review - Please review screenshots, then restart build.

  • ❌ drive : ClassicationScenario 2- Classification actions on file : https://visualreview.cozycloud.cc/#/5/22/353
  • ❌ drive : ClassicationScenario 3- Trash and Restore : https://visualreview.cozycloud.cc/#/5/24/354
  • ❌ drive : PublicViewerFeature 2- Go to public link and download files : https://visualreview.cozycloud.cc/#/5/28/358
  • ❌ drive : PublicViewerFeature 3- Cleanup Data : https://visualreview.cozycloud.cc/#/5/29/359

    		•

    cedricmessiant
    cedricmessiant approved these changes Apr 16, 2019
    View reviewed changes
    Copy link
    Contributor

    @cedricmessiant cedricmessiant left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Good!

    @Crash-- Crash-- merged commit 1a06967 into master Apr 16, 2019
    @Crash-- Crash-- deleted the fix/DefensiveCode branch April 16, 2019 14:11
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @cedricmessiant cedricmessiant cedricmessiant approved these changes

    @y-lohse y-lohse Awaiting requested review from y-lohse

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @Crash-- @cozy-bot @cedricmessiant