Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enzyme #3243

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Remove enzyme #3243

merged 3 commits into from
Nov 7, 2024

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Nov 7, 2024

### ✨ Features

*

### 🐛 Bug Fixes

*

### 🔧 Tech

* Remove enzyme

Copy link

bundlemon bot commented Nov 7, 2024

BundleMon

Files updated (2)
Status Path Size Limits
public/drive.(hash).js
1.57MB (+2.66KB +0.17%) 1.7MB
vendors/drive.(hash).js
1.79MB (+2.46KB +0.13%) 2MB
Unchanged files (16)
Status Path Size Limits
public/pdf.worker.entry.(hash).worker.js
345.35KB 350KB
services/qualificationMigration/drive.js
282.15KB 500KB
services/dacc/drive.js
263.08KB 500KB
app/drive.(hash).js
161.01KB 300KB
public/cozy-client-js.js
159.28KB 160KB
intents/drive.(hash).js
87.66KB 190KB
public/drive.(hash).min.css
39.94KB 100KB
onlyOffice/slide.pptx
24.83KB 25KB
app-drive.(hash).min.css
10.73KB 56KB
intents-drive.(hash).min.css
7.89KB 40KB
onlyOffice/text.docx
5.85KB 6KB
onlyOffice/spreadsheet.xlsx
5.02KB 6KB
manifest.webapp
1.87KB 2KB
index.html
597B 1KB
intents/index.html
507B 1KB
manifest.json
185B 1KB

Total files change +5.12KB +0.11%

Groups updated (2)
Status Path Size Limits
public/**
2.11MB (+2.66KB +0.12%) -
vendors/**
1.79MB (+2.46KB +0.13%) -
Unchanged groups (5)
Status Path Size Limits
services/**
545.23KB -
app/**
161.01KB -
intents/**
88.15KB -
onlyOffice/**
35.7KB -
img/**
5.85KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

@JF-Cozy JF-Cozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👍

est-ce que tu as mis les différents exemples dans la carte ? Peut-être que lier la PR suffit remarque... ou lier les cartes entre elles

{ isEncryptedFolder: false }
)
})
it('should dispatch a createFolder action on submit', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on devrait laisse le describe pour apporter du contexte / isoler le test non ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avant il y avait deux describe imbriqués, donc ce test est encore dans un describe('AddFolder', ...)

CURRENT_FOLDER_ID,
{ isEncryptedFolder: false }
expect.anything(),
expect.anything()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

à ce compte là et vu le titre du test on peut peut-être simplement faire toHaveBeenCalled()

Pourquoi est-ce qu'on supprime la partie vault d'ailleurs ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En fait le test précédent couvrait énormément de choses mais mal, tandis que maintenant on ne teste plus que simplement le composant AppFolder (l'objectif du test initial ?). C'est pour ça qu'il n'y a plus besoin de la partie vault.

J'ai renommé le test qu'il corresponde mieux, mais je préfère garder le toHaveBeenCalledWith pour pouvoir tester le 1er argument.

@zatteo
Copy link
Contributor Author

zatteo commented Nov 7, 2024

👏 👍

est-ce que tu as mis les différents exemples dans la carte ? Peut-être que lier la PR suffit remarque... ou lier les cartes entre elles

J'avais déjà mis chaque PR dans les cartes, et toutes les cartes sont liés par la milestone. Mais j'en ai profité pour aussi rajouter les liens de PR dans le paper 👍

@zatteo zatteo force-pushed the feat/remove-enzyme branch from 31751e7 to 2785d3a Compare November 7, 2024 14:31
@zatteo zatteo merged commit 784a6a2 into master Nov 7, 2024
4 checks passed
@zatteo zatteo deleted the feat/remove-enzyme branch November 7, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants