fix: Add Hermes to iOS linked libraries #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
approved these changes
Nov 2, 2022
When doing a fresh build from scratch, the app would crash on startup with the following error `Library not loaded: @rpath/hermes.framework/hermes` To fix this we need to add Hermes to project's linked libraries and into embedded libraries More info: facebook/react-native#34601 (comment)
Ldoppea
force-pushed
the
fix/hermes_build_link
branch
from
370cc56 to
801b023
Compare
|
I force-pushed some new config : https://github.com/cozy/cozy-flagship-app/compare/370cc56f243a678bc1f825ff8781c97a15e75cac..801b023e16c6e721f9564f6c462927658d165cf7 Previous edits were not enough to make the app work correctly. They only allowed to run the app on iOS simulators using XCode debug, but the app would still crash on physical device or in simulator without XCode (re-run previous build). To make it work on every scenario I add to add Hermes to Embedded libraries as stated in facebook/react-native#34601 (comment) |
Crash--
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a fresh build from scratch, the app would crash on startup with the following error
Library not loaded: @rpath/hermes.framework/hermesTo fix this we need to add Hermes to project's linked libraries
More info: facebook/react-native#34601 (comment)