Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update DataList and AppList headers #541

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

vdnj
Copy link
Contributor

@vdnj vdnj commented Dec 19, 2022

  • Desktop: h3 for "Permissions" title
  • Mobile: Header in cozy bar
  • Mobile: Back arrow in cozy bar

Capture d’écran 2022-12-19 à 14 08 34

Capture d’écran 2022-12-19 à 14 08 45

- Desktop: h3 for "Permissions" title
- Mobile: Header in cozy bar
- Mobile: Back arrow in cozy bar
@bundlemon
Copy link

bundlemon bot commented Dec 19, 2022

BundleMon

Files updated (2)
Status Path Size Limits
app/settings.(hash).js
82.95KB (-22B -0.03%) -
intents/settings.(hash).js
41.8KB (-22B -0.05%) -
Unchanged files (14)
Status Path Size Limits
vendors/settings.(hash).js
869.33KB -
img/export-cozy-mail.(hash).svg
27.88KB -
app-settings.(hash).min.css
11.49KB -
img/import-cozy.(hash).svg
11.28KB -
img/double_authent_prez_banner.(hash).svg
4.44KB -
img/protect_data_point.(hash).svg
4.17KB -
img/niv_secu_point.(hash).svg
1.56KB -
intents-settings.(hash).min.css
1.28KB -
img/icon-bills.(hash).svg
719B -
img/icon-laptop.(hash).svg
437B -
img/icon-arrow-left.(hash).svg
419B -
img/icon-question-mark.(hash).svg
379B -
img/icon-check.(hash).svg
367B -
img/icon-phone.(hash).svg
342B -

Total files change -44B 0%

Groups updated (1)
Status Path Size Limits
**/*.js
994.08KB (-44B 0%) +5%
Unchanged groups (2)
Status Path Size Limits
img/.
51.93KB +5%
**/*.css
42.82KB +5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@vdnj vdnj marked this pull request as ready for review December 19, 2022 15:03
@@ -19,7 +19,9 @@ jest.mock('react-router-dom', () => {
})

jest.mock('cozy-client')

jest.mock('components/PageTitle', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to mock PageTitle here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, test fails if I don't do it

@vdnj vdnj merged commit 4a1f1a6 into master Dec 20, 2022
@vdnj vdnj deleted the applist-datalist-heade-updates branch December 20, 2022 11:12
@cozy cozy deleted a comment from cozy-bot Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants