Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Export Link #544

Merged
merged 1 commit into from
Dec 29, 2022
Merged

fix: Export Link #544

merged 1 commit into from
Dec 29, 2022

Conversation

Crash--
Copy link
Contributor

@Crash-- Crash-- commented Dec 29, 2022

It seems that we migrated Settings to
react router v6, but we still try to read
from this.props.match to get access to the
URL... Let's use the useParams hooks.

🐛 Export URL was not working for the end user 

It seems that we migrated Settings to
react router v6, but we still try to read
from this.props.match to get access to the
URL... Let's use the useParams hooks.
@acezard acezard self-requested a review December 29, 2022 09:57
@bundlemon
Copy link

bundlemon bot commented Dec 29, 2022

BundleMon

Files updated (1)
Status Path Size Limits
app/settings.(hash).js
82.9KB (-45B -0.05%) -
Unchanged files (15)
Status Path Size Limits
vendors/settings.(hash).js
869.33KB -
intents/settings.(hash).js
41.79KB -
img/export-cozy-mail.(hash).svg
27.88KB -
app-settings.(hash).min.css
11.49KB -
img/import-cozy.(hash).svg
11.28KB -
img/double_authent_prez_banner.(hash).svg
4.44KB -
img/protect_data_point.(hash).svg
4.17KB -
img/niv_secu_point.(hash).svg
1.56KB -
intents-settings.(hash).min.css
1.28KB -
img/icon-bills.(hash).svg
719B -
img/icon-laptop.(hash).svg
437B -
img/icon-arrow-left.(hash).svg
419B -
img/icon-question-mark.(hash).svg
379B -
img/icon-check.(hash).svg
367B -
img/icon-phone.(hash).svg
342B -

Total files change -45B 0%

Groups updated (1)
Status Path Size Limits
**/*.js
994.01KB (-45B 0%) +5%
Unchanged groups (2)
Status Path Size Limits
img/.
51.93KB +5%
**/*.css
42.82KB +5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Crash-- Crash-- merged commit 00b8dea into master Dec 29, 2022
@Crash-- Crash-- deleted the fix/export branch December 29, 2022 10:06
@cozy cozy deleted a comment from cozy-bot Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants