Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country metadata qualification wasn't correctly editable #704

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Dec 18, 2024

Nous avons introduit un bug avec la PR #681 . Initialement on avait le souci suivant : pour les paper qui avaient un country (driver_license et national_id_card), pour le country FR de ces papiers on ne pouvait pas éditer cet metadata (country) car lors d'une édition, on cherche la step associée. Et il n'y avait pas de step pour ces papiers FR, c'était implicite.

On a alors corrigé #681 de sorte qu'on prenne toujours la step foreign. Ce qui fonctionne pour la metadata country. Or ça posait souci pour les autres metadata, par exemple AObtention de driver_license, car spécifique à la version FR du papier.

Ici on revient donc sur l'approche initiale, en rajoutant la step manquante, mais en la masquant dans le processus de création (car la valeur est implicite).

Copy link

bundlemon bot commented Dec 18, 2024

BundleMon

Files updated (3)
Status Path Size Limits
vendors/mespapiers.(hash).js
2.03MB (+473B +0.02%) -
intents/mespapiers.(hash).js
88.55KB (+71B +0.08%) -
app/mespapiers.(hash).js
1.64MB (+58B 0%) -
Unchanged files (38)
Status Path Size Limits
services/expiration/mespapiers.js
1.75MB -
services/metadataMigration/mespapiers.js
399.64KB -
services/launchTriggers/mespapiers.js
397.15KB -
img/IlluPassportDate.(hash).png
38.4KB -
img/IlluPassportNumber.(hash).png
37.98KB -
img/IlluPassport.(hash).png
37.87KB -
vendors-mespapiers.(hash).(hash).min.css
36.54KB -
img/IlluNationalHealthInsuranceCardNumber.(ha
sh).png
24.89KB -
img/IlluNationalHealthInsuranceCardDateHelp.(
hash).png
24.64KB -
img/IlluCafNumberHelp.(hash).png
21.67KB -
img/IlluIdCardNumberHelp.(hash).png
13KB -
img/IlluDriverLicenseBack.(hash).png
12.72KB -
img/IlluIdCardFront.(hash).png
12.58KB -
img/IlluIdCardBack.(hash).png
12.43KB -
img/IlluResidencePermitExpirationDateHelp.(ha
sh).png
12.17KB -
img/IlluResidencePermitNumberHelp.(hash).png
12.16KB -
img/IlluIdCardExpirationDateHelp.(hash).png
12.09KB -
img/IlluResidencePermitFront.(hash).png
12.08KB -
img/IlluDriverLicenseNumberHelp.(hash).png
11.93KB -
img/IlluDriverLicenseFront.(hash).png
11.85KB -
img/IlluDriverLicenseObtentionDateHelp.(hash)
.png
11.74KB -
img/IlluResidencePermitBack.(hash).png
11.01KB -
img/QRCode.(hash).png
9.77KB -
img/IlluNationalHealthInsuranceCardFront.(has
h).png
9.39KB -
img/IlluVehicleRegistration.(hash).png
8.92KB -
img/IlluNewNationalIdCardFront.(hash).png
8.65KB -
img/IlluOldNationalIdCardFront.(hash).png
7.86KB -
img/IlluDiploma.(hash).png
5.59KB -
img/IlluIBAN.(hash).png
3.81KB -
img/IlluCovidVaccineCertificate.(hash).png
2.96KB -
img/IlluInvoice.(hash).png
2.33KB -
img/IlluWorkContract.(hash).png
2.24KB -
img/marker-icon.(hash).png
1.45KB -
img/layers-2x.(hash).png
1.25KB -
img/layers.(hash).png
719B -
app-mespapiers.(hash).min.css
569B -
img/appstore.(hash).png
362B -
img/playstore.(hash).png
328B -

Total files change +602B +0.01%

Groups updated (1)
Status Path Size Limits
**/*.js
6.77MB (+602B +0.01%) -
Unchanged groups (2)
Status Path Size Limits
img/.
401.43KB -
**/*.css
37.54KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@JF-Cozy JF-Cozy merged commit 9d0d0ed into master Dec 18, 2024
2 checks passed
@JF-Cozy JF-Cozy deleted the feat/VER-1156 branch December 18, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant