Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Query classes #26

Merged
merged 6 commits into from
Apr 12, 2023
Merged

Refactor Query classes #26

merged 6 commits into from
Apr 12, 2023

Conversation

valencik
Copy link
Collaborator

@valencik valencik commented Apr 10, 2023

Renames the Query classes to ditch the Q suffix where possible.
When a class name would conflict with a Scala standard library class, like Range or Regex we use the prefix Term resulting in TermRange and TermRegex.
This also helps to indicate that these are term matching queries, as opposed to a boolean combination of queries or a field query.

Additionally we add apply methods to And, Or, and Group, that use varargs for conveniently constructing queries.
Closes #12

@valencik valencik self-assigned this Apr 10, 2023
@valencik valencik marked this pull request as ready for review April 11, 2023 00:07
@valencik valencik requested a review from samspills April 11, 2023 00:07
@valencik valencik merged commit ce24781 into main Apr 12, 2023
@valencik valencik deleted the helpers branch October 21, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helpers for building Query
2 participants