Multiquery #28
Merged
Multiquery #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samspills
approved these changes
Apr 12, 2023
| def mapLast(f: Query => Query): MultiQuery = | ||
| if (qs.size == 1) MultiQuery(NonEmptyList.one(f(qs.head))) | ||
| else { | ||
| val newT = qs.tail.init :+ f(qs.last) |
There was a problem hiding this comment.
I always forget about init, nice
There was a problem hiding this comment.
I don't really understand the naming, but yeah, it's handy.
Sucks that changing the last element is so expensive though.
| def assertSingleTerm(r: Either[Error, MultiQuery], expected: Query)(implicit | ||
| loc: munit.Location | ||
| ) = | ||
| assertEquals(r, Right(MultiQuery(NonEmptyList.one(expected)))) |
There was a problem hiding this comment.
Do you still need the non empty list here? Can't you just pass expected as the head to MultiQuery?
| loc: munit.Location | ||
| ) = | ||
| assertEquals(r, Right(NonEmptyList.one(expected))) | ||
| assertEquals(r, Right(MultiQuery(NonEmptyList.one(expected)))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
MultiQueryclass that wraps aNonEmptyList[Query].It's main purpose is to change the parser return type from
Either[Error, NonEmptyList[Query]]toEither[Error, MultiQuery]and thus be one lessNonEmptyListend users have to deal with. Additionally it serves a great place to hold themapLastmethod.Closes #24