Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type arg of points being used to create lines #41

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

danielfalbo
Copy link
Contributor

Lines require Point<ld>s instead of Point<ll>s

`Line`s require `Point<ld>`s instead of `Point<ll>`s
Copy link
Contributor

@podd0 podd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can shorten the code for dist_point_segnent by removing the pld variable and unnecessary .to_ld()s. Also maybe that function should be in a different file (maybe in line.h) as it's not really about polygons

@danielfalbo
Copy link
Contributor Author

right! cleaned.

dist_point_segment is used in dist_point_poly, that's why it's in the polygon module probably.

Copy link
Contributor

@podd0 podd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@podd0 podd0 merged commit 1529696 into cp-sapienza:master Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants