internal/ethapi: add comment explaining return of nil instead of error (

ethereum#25097) Co-authored-by: Felix Lange <fjl@twurst.com>
cp-yoonjin · Jun 26, 2023 · 3dc5492 · 3dc5492
1 parent 046317a
commit 3dc5492
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/internal/ethapi/api.go b/internal/ethapi/api.go
@@ -1752,6 +1752,8 @@ func (s *PublicTransactionPoolAPI) GetRawTransactionByHash(ctx context.Context,
 func (s *PublicTransactionPoolAPI) GetTransactionReceipt(ctx context.Context, hash common.Hash) (map[string]interface{}, error) {
 	tx, blockHash, blockNumber, index, err := s.b.GetTransaction(ctx, hash)
 	if err != nil {
+		// When the transaction doesn't exist, the RPC method should return JSON null
+		// as per specification.
 		return nil, nil
 	}
 	receipts, err := s.b.GetReceipts(ctx, blockHash)