Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
eth/tracers/js: drop duktape engine (ethereum#24934)
This PR also comes with 2 fixes in the Goja tracer and one small behavioural change: I had handled errors in the native Go functions by panicing. My oversight was that Goja only handles panics with a Goja.Value as argument. The difference is panic(goja.Value) allows JS to catch the exception whereas Interrupt(error) doesn't. There was a race in how I handled Stop. Because of 1. some of the methods that simply return nil on error (like memory.slice) now throw an exception.
- Loading branch information