Skip to content

Commit

Permalink
cleanup spurious comments and info log. (envoyproxy#19968)
Browse files Browse the repository at this point in the history
Signed-off-by: Joshua Marantz <jmarantz@google.com>

Commit Message: Demotes an info log to a debug log, and removes some spurious comments
Additional Description:
Risk Level: low
Testing: //test/server/admin/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
  • Loading branch information
jmarantz authored Feb 15, 2022
1 parent f8fd6e3 commit d1f5c2b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion source/server/admin/admin.cc
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ Http::Code AdminImpl::runCallback(absl::string_view path_and_query,
Http::ResponseHeaderMap& response_headers,
Buffer::Instance& response, AdminStream& admin_stream) {
HandlerPtr handler = findHandler(path_and_query, admin_stream);
Http::Code code = handler->start(/*path_and_query, */ response_headers);
Http::Code code = handler->start(response_headers);
bool more_data;
do {
more_data = handler->nextChunk(response);
Expand Down
4 changes: 2 additions & 2 deletions source/server/admin/admin_filter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ void AdminFilter::onComplete() {
auto header_map = Http::ResponseHeaderMapImpl::create();
RELEASE_ASSERT(request_headers_, "");
Admin::HandlerPtr handler = admin_handler_fn_(path, *this);
Http::Code code = handler->start(/*path, */ *header_map);
Http::Code code = handler->start(*header_map);
Utility::populateFallbackResponseHeaders(code, *header_map);
decoder_callbacks_->encodeHeaders(std::move(header_map), false,
StreamInfo::ResponseCodeDetails::get().AdminFilterResponse);
Expand All @@ -78,7 +78,7 @@ void AdminFilter::onComplete() {
Buffer::OwnedImpl response;
more_data = handler->nextChunk(response);
bool end_stream = end_stream_on_complete_ && !more_data;
ENVOY_LOG_MISC(info, "nextChunk: response.length={} more_data={} end_stream={}",
ENVOY_LOG_MISC(debug, "nextChunk: response.length={} more_data={} end_stream={}",
response.length(), more_data, end_stream);
if (response.length() > 0 || end_stream) {
decoder_callbacks_->encodeData(response, end_stream);
Expand Down

0 comments on commit d1f5c2b

Please sign in to comment.