Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant wheel dep from pyproject.toml #60

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Aug 31, 2022

Remove the redundant wheel dependency, as it is added by the backend
automatically. Listing it explicitly in the documentation was
a historical mistake and has been fixed since, see:
pypa/setuptools@f7d30a9

Remove the redundant `wheel` dependency, as it is added by the backend
automatically.  Listing it explicitly in the documentation was
a historical mistake and has been fixed since, see:
pypa/setuptools@f7d30a9
@cpburnz cpburnz merged commit c0ffa91 into cpburnz:master Sep 1, 2022
@cpburnz
Copy link
Owner

cpburnz commented Sep 1, 2022

Thanks for fixing this.

@mgorny mgorny deleted the wheel-dep branch September 1, 2022 06:54
@mgorny
Copy link
Contributor Author

mgorny commented Sep 1, 2022

Thanks! Could you tell me where did that wheel dep come from? I'm trying to fix all the obsolete docs but not sure where it is still listed.

@cpburnz
Copy link
Owner

cpburnz commented Sep 1, 2022

I included the wheel dependency to be safe because it was inconsistently used. I've been looking into pyproject.toml in passing for the past half year. In particular, I still see it at:

The documentation for pyproject.toml is getting better but I still contend it is a mess. The PEPs are completely useless because you don't know what is actually supported. The only useful piece of documentation I've found is Configuring setuptools using pyproject.toml files which is relatively recent, and digging into what other projects do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants