[Enhancement] Update Notifications Plugin to provide Package Message #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, will look into this tomorrow :) |
hibitness-quan-nguyen2
pushed a commit
to hibitness/flutter-plugins
that referenced
this pull request
Dec 18, 2023
…ation-message-data [Enhancement] Update Notifications Plugin to provide Package Message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notifications package does provide
packageNamefrom the StatusBarNotification object but also wanted to provide the notification message (body) on the payload.This PR address that need by providing it as
HashMapwith the keyspackageNameandpackageMessagejust in case someone wants to use such data on another app.Also I updated the
.gitignorefile to handle extra files generated while using vs-code java extension (it is a bug).Cheers! 🍰