Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back make xcode in the Makefile #310

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

nandodelauni
Copy link
Contributor

🎩 What is the goal?

While trying to contribute to the project I realized that the make xcode action documented in the README is no longer available. The goal is to add it back.

🔨 How is it being implemented?

By adding the action to the Makefile file.

Copy link
Owner

@cpisciotta cpisciotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this contribution!

@cpisciotta cpisciotta merged commit e7289f3 into cpisciotta:main Aug 20, 2024
9 of 11 checks passed
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.85%. Comparing base (2891bc1) to head (b19f9c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files          14       14           
  Lines        1651     1651           
=======================================
  Hits         1434     1434           
  Misses        217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nandodelauni nandodelauni deleted the add-xcode-to-makefile branch September 20, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants