Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make capture groups work for swift testing in combination with XCTestcases in same target #326

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

bobvoorneveld
Copy link
Contributor

Accidentally closed #319 when getting the latest commits from master.

Changed the PR to have the requested changes from @cpisciotta.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (ebb37ba) to head (b8171aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files          14       14           
  Lines        2304     2304           
=======================================
  Hits         2045     2045           
  Misses        259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@cpisciotta cpisciotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @bobvoorneveld! LGTM 🚢

@cpisciotta cpisciotta merged commit e47d52c into cpisciotta:main Oct 21, 2024
13 checks passed
@cpisciotta
Copy link
Owner

This change is available starting in 2.14.1! Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants