Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elisp package #42

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

syohex
Copy link
Contributor

@syohex syohex commented May 6, 2021

  • Add dependency header
  • Add missing autoload cookie

- Add dependency header
- Add missing autoload cookie
@cpitclaudel
Copy link
Owner

Is this needed? I intended Flycheck to be optional, and I thought the code worked fine if it wasn't installed.

@syohex
Copy link
Contributor Author

syohex commented May 6, 2021

(file-missing Cannot open load file No such file or directory flycheck)

If flycheck is not installed then above error occurs.

(require 'flycheck)

Because this require does not specify noerror argument(3rd argument)

(flycheck-define-command-checker 'alectryon
"Flycheck checker for literate Coq."
:command '("python3"
(eval (alectryon--locate-executable))
"--stdin-filename" source-original
"--frontend" (eval (alectryon--mode-case "coq+rst" "rst"))
"--backend" "lint"
"-")
:standard-input t
:error-parser #'alectryon--parse-errors
:enabled (lambda () (or (not (fboundp 'flycheck-python-find-module))
(flycheck-python-find-module 'alectryon "docutils")))
:predicate (lambda () alectryon-mode)
:verify (lambda (_checker)
(append (alectryon--flycheck-verify-enabled)
(when (fboundp 'flycheck-python-verify-module)
(flycheck-python-verify-module 'alectryon "docutils"))))
:modes '(coq-mode rst-mode))

This code is evaluated at load time.

@cpitclaudel
Copy link
Owner

Yes of course, how silly of me. Thanks.

@cpitclaudel cpitclaudel merged commit 41859f1 into cpitclaudel:master May 6, 2021
@syohex syohex deleted the fix-elisp-packaging branch May 6, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants