Add preamble and copy assets #47
Conversation
alectryon/html.py
Outdated
| @@ -38,8 +38,10 @@ class ASSETS: | |||
|
|
|||
| ALECTRYON_CSS = ("alectryon.css",) | |||
| ALECTRYON_JS = ("alectryon.js",) | |||
| ALECTRYON_STY = ("alectryon.sty",) | |||
There was a problem hiding this comment.
This should be in latex.py rather than in html.py
There was a problem hiding this comment.
I have created a assets.py to group all ASSET class.
And move function copy_assets.
There was a problem hiding this comment.
I'd prefer to keep html.py and latex.py self-contained, keeping the assets in each of the relevant classes. WDYT?
There was a problem hiding this comment.
I'm thinking that the copy_asset function doesn't really have a place in html.py anymore, since it's now also used to copy latex assets.
And I think is more elegant to have one class ASSET and make inheritance to make other assets class (even if is for one field).
But if you think it's better to just move the latex assets, I can roll back in this way.
There was a problem hiding this comment.
How about moving copy_asset to cli.py? It's only used there AFAICT.
There was a problem hiding this comment.
Yes we can do this.
Because the function is use just in cli.py, and we set ASSETS.PATH in cli.py also (and change name to ASSETS_PATHS).
There was a problem hiding this comment.
Yup, I think that's perfect, thanks!
|
Great work, thanks! To modify the header, I think you want to remove or change things |
alectryon/html.py
Outdated
|
|
||
| ADDITIONAL_HEADS = [ | ||
| '<meta name="viewport" content="width=device-width, initial-scale=1">' | ||
| ] | ||
|
|
||
| class ASSETS: | ||
| PATH = path.join(path.dirname(_SELF_PATH), "assets") | ||
|
|
||
| PATH = Path(__file__).parent / "assets" |
There was a problem hiding this comment.
One problem with using Path classes everywhere is that other code doesn't always expect them, so in testing the previous patch I reverted some of these because they confused Sphinx.
There was a problem hiding this comment.
To fix it, I transform Path to str in sphinx.py
There was a problem hiding this comment.
That works, but it may also break other Alectryon drivers out there; there may not be too many, but I know I have at least one like that locally, so I'd prefer to stick with the string-based version, just to minimize changes.
There was a problem hiding this comment.
Thanks, let me know when I should review/merge
start974
force-pushed
the
rst+latex
branch
4 times, most recently
from
245ef8f to
5872352
Compare
|
Rebased and merged, thanks! |
|
Released in v1.2 |
I have added preamble to use package style "alectryon.sty" and "tango_subtle.sty".
And I add a copy of their assets styles files associate to destination.
I cannot compile the PDF associate, for this latex. I mean, we need to remove docutils packages imported, but I can't found this options in documentation.