-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headers module #74
base: master
Are you sure you want to change the base?
Headers module #74
Conversation
Would like to get cross-references in advance section to other modules which are coupled to headers, such as classes, templates, modules, etc.
/ok-to-test |
feeling of small-group was to omit advanced section, as each advanced topic seemed more relevant to a different module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, work.
@rwdougla What's the status of this topic, should we table it for a SG20 discussion? It seems quite ready.
@rwdougla could you please have a look and accept the changes? |
@vulder Perfect. Thanks. We will work next week on the lambda pull request. |
@diehlpk Please have a look, I cleaned up the few open points. If there are no further problems to address, I would mark the PR tentative ready for the next online SG20 meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Circular dependencies can cause confusion. Care should be taken in identifying such | ||
|
||
#### Points to cover | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking at the points to cover in the SG20 meeting, we found that the points to cover are small/less that what is part of the ASBATS. SG20 suggests to extend the points to cover to include content wise what is asked for in the ASBATS
resolves #3