Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers module #74

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Headers module #74

wants to merge 12 commits into from

Conversation

rwdougla
Copy link
Contributor

@rwdougla rwdougla commented Feb 23, 2022

resolves #3

Would like to get cross-references in advance section to other modules which are coupled to headers, such as classes, templates, modules, etc.
@vulder vulder linked an issue Apr 29, 2022 that may be closed by this pull request
@vulder
Copy link
Collaborator

vulder commented Jul 8, 2022

/ok-to-test

feeling of small-group was to omit advanced section, as each advanced topic seemed more relevant to a different module
@rwdougla rwdougla marked this pull request as ready for review January 17, 2023 16:12
@rwdougla rwdougla changed the title WIP: Straw-man "Headers" for small-group session Straw-man "Headers" for small-group session Jan 17, 2023
@rwdougla rwdougla changed the title Straw-man "Headers" for small-group session Headers module Jan 17, 2023
Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, work.

@rwdougla What's the status of this topic, should we table it for a SG20 discussion? It seems quite ready.

@diehlpk
Copy link
Contributor

diehlpk commented Jan 8, 2025

@rwdougla could you please have a look and accept the changes?

@vulder
Copy link
Collaborator

vulder commented Jan 22, 2025

@diehlpk I talked to @rwdougla. I'll take care of the PR on the weekend and clean in up :)

@diehlpk
Copy link
Contributor

diehlpk commented Jan 22, 2025

@vulder Perfect. Thanks. We will work next week on the lambda pull request.

@vulder vulder requested review from diehlpk and vulder January 26, 2025 13:28
@vulder
Copy link
Collaborator

vulder commented Feb 12, 2025

@diehlpk Please have a look, I cleaned up the few open points. If there are no further problems to address, I would mark the PR tentative ready for the next online SG20 meeting.

Copy link
Contributor

@diehlpk diehlpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vulder vulder added the Tentatively ready Ready for a final review in SG20 label Feb 12, 2025
* Circular dependencies can cause confusion. Care should be taken in identifying such

#### Points to cover

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at the points to cover in the SG20 meeting, we found that the points to cover are small/less that what is part of the ASBATS. SG20 suggests to extend the points to cover to include content wise what is asked for in the ASBATS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tentatively ready Ready for a final review in SG20
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TOPIC] Headers
5 participants