Remove \xspace

[jensmaurer]

Fixes #1433.

This removes lots of kerning ugliness when (e.g.) a \grammarterm is followed by a punctuator. It's also a surprise to notice all the places where we actually had superfluous whitespace in the document.

[godbyk]

You might also consider \Cpp~2003 if you want to keep 'C++ 2013' from splitting across two lines.

[jensmaurer]

Good idea. Applied.

[jensmaurer]

I have run "diffpdf" in "Words" mode (to show any egregious accidents), and other than pagination changes, only substantial whitespace improvements showed up. We sometimes had inter-word space between an italics term and a subsequent comma, for example.

Overfull hboxes have improved slightly in severity (maybe because of additional kerning), but have not changed in number. Ah, I've fixed one in [alg.merge] that popped up.

The index has also improved, because two separate entries for new-expression got merged into one.

[jensmaurer]

Rebased.

[Eelis]

This is really great! (Needs another rebase though)

[jensmaurer]

Rebased.

[tkoeppe]

Note that if there are genuine errors in the current text that you discovered as part of the change, I am sympathetic towards fixing those separately in advance of this change. No need to ship a standard with known warts.

[jensmaurer]

@tkoeppe : Do you consider my pictures above "errors"?

[tkoeppe]

@jensmaurer: Yes, definitely, things like the space in "linkage ," is definitely something I'd consider borderline broken.

[jensmaurer]

Rebased.

[Eelis]

Shouldn't the \opt go outside the \grammarterm?

[burblebee]

Yes, I believe it should. I see other places where grammarterm has problems as well, as can be seen in this grep:

$grep "grammarterm.*\<opt\>" *.tex
declarations.tex:\tcode{typename}\opt{} \grammarterm{nested-name-specifier}\opt{} \grammarterm{template-name}
declarations.tex:``\tcode{enum} \grammarterm{nested-name-specifier\opt} \grammarterm{identifier}''
declarations.tex:\grammarterm{attribute-specifier-seq\opt} \grammarterm{identifier}~(\ref{dcl.type.elab}), or
declarators.tex:is of the form \grammarterm{attribute-specifier-seq\opt}
declarators.tex:\grammarterm{attribute-specifier-seq\opt}
declarators.tex:\grammarterm{cv-qualifier-seq\opt} \grammarterm{ref-qualifier\opt}
declarators.tex:\grammarterm{cv-qualifier-seq}\opt \grammarterm{ref-qualifier}\opt
expressions.tex:parameter-type-list \cvqual{cv} \grammarterm{ref-qualifier\opt} returning \tcode{T}'', then
iostreams.tex:\grammarterm{root-name\opt},
iostreams.tex:\grammarterm{root-directory\opt}, 

Another editorial issue?

fwiw, I think the above should instead be coded as:

\grammarterm{root-name}\opt{},
\grammarterm{root-directory}\opt{},

[jensmaurer]

@burblebee: It's an express change in this patch series to switch from blah\opt{} to \opt{blah}, because it makes it less likely to get a spacing accident by forgetting the empty {}.

[tkoeppe]

In the meantime, I'm sending out #1544 to just address the appalling spacing issues in basic.link.

[jensmaurer]

Rebased (again).

[Eelis]

Another bad xspace space that might be worth fixing asap is the one resulting from the use of \term in

https://github.com/cplusplus/draft/blob/master/source/expressions.tex#L4831

In C++98, there was no space there.

[tkoeppe]

@Eelis: Fixed by 8d3cba2, thanks.

[Eelis]

Perhaps now would be a good time to rebase/apply this?

[jensmaurer]

Rebased.

[tkoeppe]

Rebase, Dr Freeman.

[Eelis]

It was mentioned on the mailing list that it would be desirable to have the new \opt reject empty arguments or arguments containing spaces. I'm a LaTeX noob, but the following seems to work:

\documentclass{article}
\usepackage{xstring}
\usepackage{ifthen}
\begin{document}
\newcommand{\opt}[1]{\IfSubStr{#1}{ }
  {\PackageError{main}{argument must not contain spaces}{}}
  {\ifthenelse{\equal{#1}{}}
    {\PackageError{main}{argument must not be empty}{}}
    {#1\ensuremath{_\mathit{opt}}}}}

hello \opt{world}
% \opt{hello world} % emits the first error
% hello world\opt{} % emits the second error
\end{document}

[tkoeppe]

Nice. Can you also make it discover linebreaks?

[Eelis]

The IfSubStr already recognizes newlines as spaces, it seems. :)

[jensmaurer]

Do we want to apply this patch series as large as it is, or should I split it into separate patches along the lines of:

• change \Cpp and friends to \Cpp{} and remove \xspace use
• change NTBS macros to \blah{} and remove \xspace use
• morph blah\opt into \opt{blah} (with Eelis' macro above)

These could be reviewed separately, making smaller chunks of changes. Opinions?

[tkoeppe]

Is this PR redundant in light of #1761?

[jensmaurer]

@tkoeppe: Yes and no. #1761 removes \xspace everywhere except for \opt, which needs special treatment (to be done later). I'll close this pull request.