Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tables] Various cleanups. #2852

Merged
merged 3 commits into from
May 20, 2019
Merged

[tables] Various cleanups. #2852

merged 3 commits into from
May 20, 2019

Conversation

jensmaurer
Copy link
Member

No visual differences, but less redundant LaTeX source.

@tkoeppe, could you please apply this?

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 30, 2019

Neat, thanks!

@jensmaurer
Copy link
Member Author

@tkoeppe, I'd like to merge this before addressing #2674. Are you actually fine with my changes?

@jensmaurer jensmaurer requested a review from tkoeppe May 2, 2019 23:01
@jensmaurer
Copy link
Member Author

@tkoeppe, sorry for pestering, but I'd like to get a second pair of eyes to ok this change before applying. Hitting "approve" would clarify whether your "neat" comment was just a general remark or actually the result of some review.

@tkoeppe
Copy link
Contributor

tkoeppe commented May 7, 2019

@jensmaurer: It wasn't a review yet; I wanted to take a closer look first. But I'm very happy with cleanup in this area. I'll try to get to this tomorrow.

@jensmaurer
Copy link
Member Author

@tkoeppe, ping?

@tkoeppe
Copy link
Contributor

tkoeppe commented May 20, 2019

Looks good, thanks a lot! This is a very nice improvement. Sorry for the delay!

@tkoeppe tkoeppe merged commit b63bcc4 into cplusplus:master May 20, 2019
@jensmaurer jensmaurer deleted the c7 branch May 20, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants