-
Notifications
You must be signed in to change notification settings - Fork 771
Page breaks (tkoeppe) #4233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page breaks (tkoeppe) #4233
Conversation
bc62d8a
to
0208a91
Compare
0208a91
to
4896c63
Compare
4896c63
to
b609f3b
Compare
Do you think we should insert a page break before [lex.literal]? Other than that, looks good to the end of Clause 6. [iterator.concept.sentinel]: wrapping of Otherwise, Clause 23 and 24 look OK. C.5.4 [diff.expr] paragraph 1 has too much vertical whitespace after the second codeblock. Same thing in C.5.2/3 and C.5.3/1 and ... looks like we get bonus vertical space everywhere that a codeblock is followed by one of our bold Annex C labels. Otherwise, Annexes look OK. Back matter: split_view::inner-iterator and ::outer-iterator are in the wrong typeface in the index of library names. |
b609f3b
to
8510088
Compare
This prevents a footnote from spanning two pages and also makes all subclause headings appear at the top of a page.
This only affects Annex A.
8510088
to
a53a988
Compare
The sentinel-for awkwardness was fixed with a single, local PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
Partially addresses #4228