Skip to content

[dcl.type.auto.deduct] Clarify initializer for placeholder type deduction. #4315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

[dcl.type.auto.deduct] Clarify initializer for placeholder type deduction. #4315

merged 1 commit into from
Jun 22, 2021

Conversation

jensmaurer
Copy link
Member

Fixes #4088

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 14, 2020

Looks reasonable; could @zygoloid perhaps confirm that this is editorial?

@tkoeppe tkoeppe requested a review from zygoloid December 14, 2020 16:36
zygoloid
zygoloid reviewed Dec 15, 2020
View reviewed changes
@jensmaurer jensmaurer requested a review from zygoloid December 15, 2020 22:00
@xmh0511 xmh0511 mentioned this pull request Apr 13, 2021
Open
@languagelawyer languagelawyer mentioned this pull request May 7, 2021
Closed
zygoloid
zygoloid reviewed Jun 1, 2021
View reviewed changes
@jensmaurer jensmaurer force-pushed the c10 branch 3 times, most recently from d92b0b2 to cd572a6 Compare June 3, 2021 22:03
@jensmaurer jensmaurer requested a review from zygoloid June 3, 2021 22:05
@jensmaurer
Copy link
Member Author

@zygoloid, I've now applied a larger hammer, which rounded a few more of the edges here.

@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jun 15, 2021
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jun 15, 2021
zygoloid
zygoloid approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@jensmaurer jensmaurer requested a review from tkoeppe June 22, 2021 19:47
@tkoeppe tkoeppe merged commit dd99020 into cplusplus:main Jun 22, 2021
@jensmaurer jensmaurer deleted the c10 branch June 22, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid approved these changes

@tkoeppe tkoeppe tkoeppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dcl.type.auto.deduct] Incorrect description of deduction for a variable with copy-initialization?
4 participants
@jensmaurer @tkoeppe @zygoloid @wg21bot