Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[input.output] Use \exposid for exposition-only names #7208

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Aug 8, 2024

Towards #5940 and #4702.

Renaming:

  • init_buf_ptrs to init-buf-ptrs,
  • emit_on_sync to emit-on-sync,
  • pathobject to path-object.

init_cnt is not changed because it should be removed.

Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice improvement and would be happy for it to be merged with or without the ok_ to ok change.

Renaming:
- `init_buf_ptrs` to _`init-buf-ptrs`_,
- `emit_on_sync` to _`emit-on-sync`_,
- `pathobject` to _`path-object`_.

`init_cnt` is not changed because it should be removed.
@frederick-vs-ja
Copy link
Contributor Author

Rebase and force-pushed to avoid merge conflict because init_cnt should be removed by #7263.

@jensmaurer jensmaurer merged commit 29c770f into cplusplus:main Sep 26, 2024
2 checks passed
@frederick-vs-ja frederick-vs-ja deleted the iostream-exposid branch September 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants