Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markup of product-type constructor call in [exec.just] #7216

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

lewissbaker
Copy link
Contributor

The \exposid{product-type} needed some extra @ symbols surrounding so that the subsequent curly-braces for the constructor call are treated as literal text.

The `\exposid{product-type}` needed some extra `@` symbols surrounding so that the subsequent curly-braces for the constructor call are treated as literal text.
@jensmaurer
Copy link
Member

No, we need backslashes before the braces.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Aug 12, 2024
@lewissbaker
Copy link
Contributor Author

No, we need backslashes before the braces.

I was copying the syntax used in other places:

Which seem to be rendering fine on https://eel.is/c++draft/

Do they also need to be changed to escape the braces with backslashes?

@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Aug 13, 2024

I was copying the syntax used in other places:

There are in either \begin{itemdecl} \end{itemdecl} or \begin{codeblock} \end{codeblock}, so the syntax is slightly different. I don't think we need to escape the braces with backslashes in such blocks.

Note that existing occurences of {} in \tcode{} (and outside of blocks) are escaped with backslashes:

draft/source/algorithms.tex

Lines 7166 to 7167 in c8f87ef

Let \tcode{comp} be \tcode{less\{\}}
and \tcode{proj} be \tcode{identity\{\}}

Use backslashes to escape instead of the @ symbol.
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Aug 14, 2024
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that looks good now.

In order to streamline future instances of the process, please consider https://github.com/cplusplus/draft/wiki/Commit-message-format and squash and force-push your commits (there should be a single commit remaining in this pull request, with a proper one-line change description, after this endeavor).

@jensmaurer jensmaurer merged commit ebef68d into cplusplus:main Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants