[expr.sub] Add missing cross-references #7688
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
reviewed
Feb 17, 2025
source/expressions.tex
Outdated
| @@ -3257,7 +3257,7 @@ | |||
| consisting of a single \grammarterm{assignment-expression}. | |||
| One of the expressions shall be a glvalue of type ``array of | |||
| \tcode{T}'' or a prvalue of type ``pointer | |||
| to \tcode{T}'' and the other shall be a prvalue of unscoped enumeration or integral type. | |||
| to \tcode{T}'' and the other shall be a prvalue of unscoped enumeration\iref{dcl.enum} or integral type. | |||
There was a problem hiding this comment.
The other changes are fine; this one feels both unneeded (enumerations aren't really strange) and asymmetrical, because there is no xref for "integral type".
I suggest to drop this part.
There was a problem hiding this comment.
Unlike unscoped enumerations, which are defined later in the wording, integral types are defined earlier, in [basic.fundamental]. So asymmetry is somewhat inevitable here. But sure, I'll drop this cross-reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds several cross-references to Declarations section, and moves reference to [over.sub] to an earlier occurrence of the term "subscript operator function".