Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3471R4 Standard library hardening #7703

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Eisenwave
Copy link
Contributor

@Eisenwave
Copy link
Contributor Author

@jwakely I have had some issues when creating this PR:

  • The new note for [string.view.access] looks as if it had a paragraph number, but it's most likely intended to be attached to the hardened precondition paragraph. I have elected to ignore the paragraph number.

  • The paper deletes "Two kinds of implementations are defined" in [intro.compliance] but the library has the same sort of wording in [compliance] (library intro). How to proceed? Delete redundant wording? Mirror changes?

  • [structure.specifications] in the paper explains "Hardened preconditions" simply with two bullets that begin with "When". This is not how we usually do things. My suggestion would be something like "If the implementation is hardened ([intro.compliance]), ..." for the first bullet, and "Otherwise, ..." for the second bullet.

  • [basic.contract.eval] is a dead reference at this point. It should be resolved after merging with contracts.

  • It was very annoying that the paper doesn't have a wording diff that follows the structure of the standard linearly. For example, the paper first has the wording diff for 23.7.3.6.3 [mdspan.mdspan.members], and then the diff for 27.7.3.6.2 [mdspan.mdspan.cons]. The only thing this accomplishes is to bully the editor, and I'm the editor, and I feel bullied!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2025-02 LWG Motion 15] P3471R4 Standard Library Hardening P3471 R3 Standard Library Hardening
1 participant