Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add working sqlite example. #579

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ScottBailey
Copy link
Contributor

This is a very simple example that adds sqlite from an amalgamation source.

@ScottBailey ScottBailey force-pushed the bailey/sqlite_example branch from 25dad15 to d867587 Compare July 30, 2024 17:43
@ScottBailey ScottBailey marked this pull request as draft July 30, 2024 17:52
@ScottBailey ScottBailey marked this pull request as ready for review July 30, 2024 17:53
URL_HASH SHA256=712a7d09d2a22652fb06a49af516e051979a3984adb067da86760e60ed51a7f5
PATCHES sqlite.patch
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the extra example, this is an interesting use of the patches command! I'm a bit torn if we should encourage the use of the patches like this as the command still seems to have some issues. Until the command is more mature I think we should still encourage the old way of adding the library without using patches:

Suggested change
if (sqlite_ADDDED)
add_library(
sqlite STATIC
${sqlite_SOURCE_DIR}/sqlite3.c
${sqlite_SOURCE_DIR}/sqlite3.h
${sqlite_SOURCE_DIR}/sqlite3ext.h
)
target_include_directories(sqlite PUBLIC SYSTEM "${sqlite_SOURCE_DIR}")
endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants