-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/save agents #185
Merged
Merged
Feature/save agents #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's here! This PR dds the ability to save/load agents, addressing #161 .
There are a few keys to the design. First of all, rather than having
agent.act(state)
andagent.eval(state)
, agents were split into a training-modeAgent
and aTestAgent
. Both types of agents can be instantiated by aPreset
:The
Preset
is a serializable object containing the hyperparameters and all necessarytorch
models. TheTestAgent
inherits a copy of the model trained by theAgent
, allowingTestAgent
s from different points in training to be stored.The second major key to the design is that the
Preset
, rather than theAgent
itself is saved:This is important because the underlying
Agent
objects are often difficult to serialize, and even if they can be serialized they can take up an excessive amount of storage (for example, a standard 1 million frame Atari replay buffer is ~7 GB).One thing to note is that while this design supports creating a training mode
Agent
with a previously trained network, it does not support a full "resume" of training, e.g., scheduler states will be reset and replay buffers will be cleared. Full resume functionality introduces many difficulties which interfere with the design of the library, however, we may implement a partial solution in the future.Example usage can be found below: