Fix violation of rule of 5 in JsonObject #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix operator[] issues in clang in another pr, merging |
TymianekPL
added a commit
that referenced
this pull request
May 23, 2025
* cppjson::JsonObject primitive, tagged union Signed-off-by: TymianekPL <tymi@tymi.org> * std::formatter specialisation for json objects Signed-off-by: TymianekPL <tymi@tymi.org> * make formatter specialisation sexy ⚡ Signed-off-by: TymianekPL <tymi@tymi.org> * sync with pr3: Changes C++23 => C++20 in .clang-format Signed-off-by: TymianekPL <tymi@tymi.org> * Add cppjson::Object Signed-off-by: TymianekPL <tymi@tymi.org> * Fix clang-format Signed-off-by: TymianekPL <tymi@tymi.org> * cppjson::Object Signed-off-by: TymianekPL <tymi@tymi.org> * mark conversions as explicitly implicit Signed-off-by: TymianekPL <tymi@tymi.org> * formatter specialisations for proxies Signed-off-by: TymianekPL <tymi@tymi.org> * Sub objects Signed-off-by: TymianekPL <tymi@tymi.org> * Fix violation of rule of 5 in JsonObject (#4) * Add declarations for JsonObject's special functions * Define copy/move constructors * Define copy/move assignment operators * Implicitly create bytes * Implicitly create bytes in exchange() * Fix includes lol (utility, cstring) * Destroy() objects * Fix ambiguous operator[] (#6) * Fix ambiguous operator[] * template typo lol * Call Destroy() in type erase Signed-off-by: TymianekPL <tymi@tymi.org> * Ensure safe cleanup of arrays Signed-off-by: TymianekPL <tymi@tymi.org> * Arrays Signed-off-by: TymianekPL <tymi@tymi.org> * add emplace * Split into multiple files & add finish arrays Signed-off-by: TymianekPL <tymi@tymi.org> --------- Signed-off-by: TymianekPL <tymi@tymi.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
object.hpp and object.cpp