OpenSSL: Fix compilation on windows msvc and ninja #461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've followed this guide
step by step carefully. [Yes]
This update will fix a toolchain.
The issue boils down that
url_sha1_openssl_windows_1_1_plus.cmake
callsconfigure_1_1_plus.cmake
And CMake populates
CXX
,CC
and other environment variables.The build fails because, the content of these variables are absolute file paths without any quotes and they are not escaped.
But openssl will use them and fails upon calling them.
The same goes for many other projects (e.g. Boost during b2) and I created this PR to show it for openssl* and get a conversation going.
My guess is that CMake actually sets these variables wrong, or Hunter should set them manually.
So I'm hoping for some feedback on how this might be solved in a better more general way.
*) unfortunately since the last version of hunter, the CI does not run the builds anymore 🤷