Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence warnings building with CMake v3.31 #768

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hjmallon
Copy link

@hjmallon hjmallon commented Dec 16, 2024

  • I've checked this Git style guide. [Yes]
  • I've checked this CMake style guide. [Yes]
  • My change will work with CMake 3.5 (minimum requirement for Hunter). [Yes]
  • I will try to keep this pull request as small as possible and will try not to mix unrelated features. [Yes]

With CMake 3.31 you get warnings if you tell cmake to use a compat version <3.10. Change the version in a backwards compatible way to silence the warnings by upping the compat version to 3.12 but leaving the min version as 3.5

See #767

Also a gate change here cpp-pm/gate#17

On modern cmake this will enable policies CMP0066 through CMP0075 (https://cmake.org/cmake/help/latest/policy/CMP0066.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant