Update minimum CMake to v3.10 #769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmallon
force-pushed
the
_hm/cmakever2
branch
from
d2a238a to
f275d6c
Compare
|
Is there an ETA on when this can be approved, or where in the progress this is? |
NeroBurner
requested changes
Apr 10, 2025
| must to be checked manually for each custom build scheme (see [CMake package default behaviour](https://github.com/ruslo/hunter/wiki/usr.adding.new.package#default-behaviour)) |
There was a problem hiding this comment.
what's the change of this line, I don't see a difference in GitHub view 🤔
| * `3.10.0`_ **Minimum required** | ||
|
|
||
| * CMake upstream dropping support for versions before 3.10 | ||
| * `CMake release notes <https://cmake.org/cmake/help/latest/release/3.31.html#deprecated-and-removed-features>`__ |
There was a problem hiding this comment.
for completeness add a link to this PR
Suggested change
| * `CMake release notes <https://cmake.org/cmake/help/latest/release/3.31.html#deprecated-and-removed-features>`__ | |
| * `CMake release notes <https://cmake.org/cmake/help/latest/release/3.31.html#deprecated-and-removed-features>`__ | |
| * Since: `PR #769 <https://github.com/cpp-pm/hunter/pull/769>`__ |
|
Just merged the Gate PR cpp-pm/gate#18 Could you update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also needs a gate update after cpp-pm/gate#18