Logarithmic funcs #536
Merged
Logarithmic funcs #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #536 +/- ##
=========================================
+ Coverage 98.8% 98.8% +0.1%
=========================================
Files 186 188 +2
Lines 11631 11653 +22
=========================================
+ Hits 11482 11509 +27
+ Misses 149 144 -5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mborland
reviewed
May 6, 2024
Comment on lines
-169
to
-188
| BOOST_DECIMAL_EXPORT template <typename T> | ||
| constexpr auto log(T x) noexcept | ||
| BOOST_DECIMAL_REQUIRES(detail::is_decimal_floating_point_v, T) | ||
| { | ||
| #if BOOST_DECIMAL_DEC_EVAL_METHOD == 0 | ||
|
|
||
| using evaluation_type = T; | ||
|
|
||
| #elif BOOST_DECIMAL_DEC_EVAL_METHOD == 1 | ||
|
|
||
| using evaluation_type = detail::promote_args_t<T, decimal64>; | ||
|
|
||
| #else // BOOST_DECIMAL_DEC_EVAL_METHOD == 2 | ||
|
|
||
| using evaluation_type = detail::promote_args_t<T, decimal128>; | ||
|
|
||
| #endif | ||
|
|
||
| return static_cast<T>(detail::log_impl(static_cast<evaluation_type>(x))); | ||
| } |
There was a problem hiding this comment.
We need to keep this part on each of the special functions to properly support the float evaluation methods. This promotes the type of x depending on the macro set and then does the calculation much like how boost math does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.