Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCC13 runner os #571

Merged
merged 2 commits into from
May 17, 2024
Merged

Update GCC13 runner os #571

merged 2 commits into from
May 17, 2024

Conversation

mborland
Copy link
Member

Github broke 22.04: actions/runner-images#9866

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.8%. Comparing base (660831d) to head (75e69d1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #571   +/-   ##
=======================================
  Coverage     98.8%   98.8%           
=======================================
  Files          192     192           
  Lines        11480   11480           
  Branches      1386    1386           
=======================================
  Hits         11341   11341           
  Misses         139     139           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 660831d...75e69d1. Read the comment docs.

@ckormanyos
Copy link
Collaborator

ckormanyos commented May 17, 2024

Hi Matt (@mborland) could you please look at the one failed run? It's not getting very far into it. Also a few comments above about constexpr-abs.

I posted here in the wrong PR. I mean my finish gammas PR.

@ckormanyos
Copy link
Collaborator

the one failed run?

Ah I see, the runner is fundamentally flawed at the moment.

@mborland
Copy link
Member Author

Since we have GCC 13 covered in Drone I am just going to delete it out of GHA until the fix it

@mborland mborland merged commit a4c4763 into develop May 17, 2024
62 checks passed
@mborland mborland deleted the fix_ci branch May 17, 2024 08:37
@ckormanyos
Copy link
Collaborator

Why does stuff like this keep happenin' on such mighty runners???!!! Good choice Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants