-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start tuning cmath functions #580
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #580 +/- ##
=========================================
+ Coverage 98.9% 99.0% +0.1%
=========================================
Files 200 200
Lines 12912 12940 +28
Branches 1487 1492 +5
=========================================
+ Hits 12766 12799 +33
+ Misses 146 141 -5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Hi Matt (@mborland) I'm gonna merge this one lickety split. I've got a goal to get to Based on experiences from other projects, it takes about a few months and another thousand lines of test code to reach |
Sounds good to me. For the new fast types I've been recycling the same test code so hopefully it doesn't drop the coverage too much. |
It's worth the effort. Those fast types will be key for clients requiring fast math on decimal types. This was really a good direction to introduce into this work. Trivial coverage, ... we will get as we evolve the LIB. This thing is moving. |
Well I made a few efforts to get better on funcs and also got a few lines covered on 128/256 bit backends. I did not quite finish everything on the (non-published) TODO list. But it's headed in the right direction. So when this thing cycles green, I'll just go ahead and push it. The battery of funcions/impl-details is really getting rather stable nowdays. Good stuff. |
Now that most
<cmath>
functions are present, the purpose of this PR is to tune them, check/extend ranges and try to hit more non-covered lines.