Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start tuning cmath functions #580

Merged
merged 9 commits into from
May 23, 2024
Merged

Start tuning cmath functions #580

merged 9 commits into from
May 23, 2024

Conversation

ckormanyos
Copy link
Collaborator

@ckormanyos ckormanyos commented May 21, 2024

Now that most <cmath> functions are present, the purpose of this PR is to tune them, check/extend ranges and try to hit more non-covered lines.

@ckormanyos ckormanyos marked this pull request as draft May 21, 2024 05:45
@ckormanyos ckormanyos self-assigned this May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.0%. Comparing base (fa54eb5) to head (266715c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #580     +/-   ##
=========================================
+ Coverage     98.9%   99.0%   +0.1%     
=========================================
  Files          200     200             
  Lines        12912   12940     +28     
  Branches      1487    1492      +5     
=========================================
+ Hits         12766   12799     +33     
+ Misses         146     141      -5     
Files Coverage Δ
include/boost/decimal/detail/cmath/exp.hpp 100.0% <100.0%> (+4.6%) ⬆️
include/boost/decimal/detail/cmath/lgamma.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/cmath/tgamma.hpp 100.0% <100.0%> (ø)
test/test_big_uints.cpp 100.0% <100.0%> (ø)
test/test_exp.cpp 100.0% <100.0%> (ø)
test/test_lgamma.cpp 100.0% <100.0%> (ø)
test/test_log.cpp 100.0% <100.0%> (ø)
test/test_tgamma.cpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/emulated128.hpp 97.7% <83.4%> (+1.2%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa54eb5...266715c. Read the comment docs.

@ckormanyos
Copy link
Collaborator Author

ckormanyos commented May 22, 2024

Hi Matt (@mborland) I'm gonna merge this one lickety split. I've got a goal to get to $99\%$ coverage soon but not quite on this one.

Based on experiences from other projects, it takes about a few months and another thousand lines of test code to reach $100\%$, which I'd like to put on the table as a reachable goal. Let's party.

@mborland mborland marked this pull request as ready for review May 22, 2024 17:49
@ckormanyos ckormanyos requested a review from mborland May 22, 2024 17:50
@mborland
Copy link
Member

Hi Matt (@mborland) I'm gonna merge this one lickety split. I've got a goal to get to $99\%$ coverage soon but not quite on this one.

Based on experiences from other projects, it takes about a few months and another thousand lines of test code to reach $100\%$, which I'd like to put on the table as a reachable goal. Let's party.

Sounds good to me. For the new fast types I've been recycling the same test code so hopefully it doesn't drop the coverage too much.

@ckormanyos
Copy link
Collaborator Author

ckormanyos commented May 22, 2024

For the new fast types I've been recycling the same test code so hopefully it doesn't drop the coverage too much.

It's worth the effort. Those fast types will be key for clients requiring fast math on decimal types. This was really a good direction to introduce into this work.

Trivial coverage, ... we will get as we evolve the LIB. This thing is moving.

@ckormanyos
Copy link
Collaborator Author

ckormanyos commented May 23, 2024

Well I made a few efforts to get better on funcs and also got a few lines covered on 128/256 bit backends. I did not quite finish everything on the (non-published) TODO list. But it's headed in the right direction. So when this thing cycles green, I'll just go ahead and push it.

The battery of funcions/impl-details is really getting rather stable nowdays. Good stuff.

@ckormanyos ckormanyos merged commit 75b07ec into develop May 23, 2024
64 checks passed
@ckormanyos ckormanyos deleted the cmath_tuning branch May 23, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants