Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dec64 multiplication #655

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Improve dec64 multiplication #655

merged 3 commits into from
Jun 14, 2024

Conversation

mborland
Copy link
Member

Closes: #653

Provides an ~40% speedup to decimal64 by replacing O(log(N)) comparisions with 1

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.5%. Comparing base (1cd6c70) to head (e57bff0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #655     +/-   ##
=========================================
- Coverage     98.5%   98.5%   -0.0%     
=========================================
  Files          221     221             
  Lines        15692   15696      +4     
  Branches      1724    1723      -1     
=========================================
- Hits         15455   15452      -3     
- Misses         237     244      +7     
Files Coverage Δ
include/boost/decimal/detail/emulated256.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/mul_impl.hpp 96.7% <100.0%> (-0.1%) ⬇️
include/boost/decimal/detail/power_tables.hpp 100.0% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd6c70...e57bff0. Read the comment docs.

@mborland mborland merged commit c7aed9d into develop Jun 14, 2024
62 checks passed
@mborland mborland deleted the dec64_div branch June 14, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decimal64 mul is slower than division by >30%
1 participant