Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellint coverage #666

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Ellint coverage #666

merged 3 commits into from
Jun 20, 2024

Conversation

ckormanyos
Copy link
Collaborator

No description provided.

@ckormanyos
Copy link
Collaborator Author

The purpose of this PR is to hit some missing ellint_1() and ellint_2() lines via adding tests and also to annotate some lines discovered that are not intended to be covered.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 96.40288% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.5%. Comparing base (d9dc532) to head (43525f2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #666     +/-   ##
=========================================
+ Coverage     98.3%   98.5%   +0.3%     
=========================================
  Files          223     223             
  Lines        16112   16176     +64     
  Branches      1776    1789     +13     
=========================================
+ Hits         15823   15931    +108     
+ Misses         289     245     -44     
Files Coverage Δ
include/boost/decimal/detail/cmath/cos.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/cmath/ellint_1.hpp 100.0% <100.0%> (+6.3%) ⬆️
include/boost/decimal/detail/cmath/ellint_2.hpp 100.0% <100.0%> (+6.0%) ⬆️
...de/boost/decimal/detail/cmath/impl/ellint_impl.hpp 100.0% <100.0%> (+13.4%) ⬆️
test/compare_dec128_and_fast.cpp 69.9% <ø> (+16.2%) ⬆️
test/test_asin.cpp 100.0% <ø> (+3.3%) ⬆️
test/test_ellint_1.cpp 100.0% <100.0%> (ø)
test/test_ellint_2.cpp 100.0% <100.0%> (ø)
...clude/boost/decimal/detail/cmath/impl/sin_impl.hpp 62.8% <50.0%> (ø)
include/boost/decimal/detail/cmath/sin.hpp 92.2% <85.0%> (-4.5%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9dc532...43525f2. Read the comment docs.

@ckormanyos
Copy link
Collaborator Author

Better, good enough to merge but we will finish even more later

@ckormanyos ckormanyos merged commit 7aceda2 into develop Jun 20, 2024
62 checks passed
@ckormanyos ckormanyos deleted the ellint_coverage branch June 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant