Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 32-bit addition implementation #689

Merged
merged 9 commits into from
Jul 1, 2024
Merged

Improve 32-bit addition implementation #689

merged 9 commits into from
Jul 1, 2024

Conversation

mborland
Copy link
Member

@mborland mborland commented Jul 1, 2024

Removes a few branches and swaps from the existing implementation
Closes: #687

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.1%. Comparing base (5719f40) to head (2a2c8f9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #689     +/-   ##
=========================================
- Coverage     99.2%   99.1%   -0.0%     
=========================================
  Files          230     230             
  Lines        16407   16386     -21     
  Branches      1791    1781     -10     
=========================================
- Hits         16262   16238     -24     
- Misses         145     148      +3     
Files Coverage Δ
include/boost/decimal/decimal32.hpp 99.8% <100.0%> (-<0.1%) ⬇️
include/boost/decimal/decimal32_fast.hpp 97.2% <100.0%> (-0.1%) ⬇️
include/boost/decimal/detail/add_impl.hpp 100.0% <100.0%> (ø)
test/test_decimal32.cpp 100.0% <100.0%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5719f40...2a2c8f9. Read the comment docs.

@mborland mborland merged commit 860c5e7 into develop Jul 1, 2024
62 checks passed
@mborland mborland deleted the add branch July 1, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework 32-bit addition impl
1 participant