Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal32 fast comps v2 #714

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Decimal32 fast comps v2 #714

merged 6 commits into from
Jul 17, 2024

Conversation

mborland
Copy link
Member

Avoid duplicate non-finite checks in decimal32_fast comparisons

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.1%. Comparing base (2a17f6e) to head (8d6bedd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #714     +/-   ##
=========================================
+ Coverage     99.1%   99.1%   +0.1%     
=========================================
  Files          230     230             
  Lines        16413   16431     +18     
  Branches      1781    1779      -2     
=========================================
+ Hits         16259   16278     +19     
+ Misses         154     153      -1     
Files Coverage Δ
include/boost/decimal/decimal32_fast.hpp 96.8% <100.0%> (+0.2%) ⬆️
include/boost/decimal/detail/comparison.hpp 99.2% <100.0%> (+0.1%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a17f6e...8d6bedd. Read the comment docs.

@mborland mborland merged commit 4bf4e48 into develop Jul 17, 2024
64 checks passed
@mborland mborland deleted the decimal32_fast_comps_v2 branch July 17, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant