Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string and string_view interfaces to from_chars #768

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Conversation

mborland
Copy link
Member

@mborland mborland commented Jan 3, 2025

Matches what the consumers asked for in boost.charconv

Closes: #764

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.7%. Comparing base (a3094df) to head (2cfee86).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #768     +/-   ##
=========================================
+ Coverage     98.7%   98.7%   +0.1%     
=========================================
  Files          223     223             
  Lines        16728   16728             
  Branches      1796    1796             
=========================================
+ Hits         16503   16504      +1     
+ Misses         225     224      -1     
Files with missing lines Coverage Δ
include/boost/decimal/charconv.hpp 79.8% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3094df...2cfee86. Read the comment docs.

@mborland mborland merged commit b9adb39 into develop Jan 3, 2025
65 checks passed
@mborland mborland deleted the str_charconv branch January 3, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add string and string_view interfaces to <charconv>
1 participant