Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 777 #778

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Fix for 777 #778

merged 3 commits into from
Jan 7, 2025

Conversation

mborland
Copy link
Member

@mborland mborland commented Jan 6, 2025

Closes: #777

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.7%. Comparing base (d470174) to head (8fe3c09).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/decimal/charconv.hpp 75.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #778     +/-   ##
=========================================
- Coverage     98.7%   98.7%   -0.0%     
=========================================
  Files          223     223             
  Lines        16742   16744      +2     
  Branches      1798    1799      +1     
=========================================
  Hits         16517   16517             
- Misses         225     227      +2     
Files with missing lines Coverage Δ
test/test_to_chars.cpp 100.0% <ø> (ø)
include/boost/decimal/charconv.hpp 79.6% <75.0%> (-0.1%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d470174...8fe3c09. Read the comment docs.

@mborland mborland merged commit 5ef5f0d into develop Jan 7, 2025
74 checks passed
@mborland mborland deleted the 777 branch January 7, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_chars fixed formatting with trailing zeros and no fractional part is incorrect
1 participant