fix: handle constructor from reference to array #923
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An automated preview of the documentation is available at https://923.mrdocs.prtest2.cppalliance.org/index.html |
isCopyOrMoveConstructorOrAssignment currently doesn't handle a constructor from a reference to array. I am not sure why this is not seen on CI, but it is reproducible from llvm 20.1.7, as available in macos homebrew.
alandefreitas
force-pushed
the
fix-constructor-from-array
branch
from
a4c5ad0 to
9f3b8bf
Compare
|
An automated preview of the documentation is available at https://923.mrdocs.prtest2.cppalliance.org/index.html |
| MRDOCS_CHECK_OR(paramRefPointeeNamed.Name, false); | ||
| auto const& paramName = paramRefPointeeNamed.Name; | ||
| auto const* paramRefPointeeNamed = get<NamedTypeInfo const*>(paramRefPointee); | ||
| if (!paramRefPointeeNamed) |
There was a problem hiding this comment.
For reference, this could be MRDOCS_CHECK_OR(paramRefPointeeNamed, false).
MRDOCS_CHECK is that pattern people use with std::expected (like ? in Rust), so that code based on error types doesn't become impossible to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isCopyOrMoveConstructorOrAssignment currently doesn't handle a constructor from a reference to array. I am not sure why this is not seen on CI, but it is reproducible from llvm 20.1.7, as available in macos homebrew.