Fix undefined behavior in case of time overflow on 32-bit platforms #1774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1762
Currently signed long int is used for storing current time in milliseconds (time is calculated by GetPlatformSpecificTimeInMillis()).
But on 32-bit platforms long could be a 32-bit number (e.g. C17 standard declares at 5.2.4.2.1 that long int should be at least 32 bits long).
Current unix timestamp in seconds is 31 bit long and timestamp in milliseconds is at least 41 bit long.
C/C++ standards declare that behavior of signed integer overflow is undefined (e.g. C17 example at 3.4.3).
The platform specific time is used only for calculating difference between end and start time. So, long could be replaced with unsigned long in that case without any negative effects.