-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove privacy-violating code fragments #1
base: master
Are you sure you want to change the base?
Conversation
@cnfree Would you be so kind to comment here, if you are willing to accept this pull request? |
@hbrands This comment and this comment seem relevant. My guess is that this pull request ultimately won't be accepted. Maintaining a fork with the goal of submitting it to the Eclipse Marketplace might be worthwhile. |
@xnrand I had this idea, too, since I really like the plugin - at least its main functionality. Anyone with experience in developing/publishing Eclipse plugins interested? I would be happy to support. |
@cnfree: Is the revenue generated from your hidden ad features that big that you can't resign from it? An alternative route would be to provide a donation option - with 400.000+ subscribers, that should work to - kind of more honest than the current, hidden approach. This pull request is meant to support you, not upset you. |
@pbi-qfs I'd be willing to assist with a fork, I do have experience with developing Eclipse plugins. You can contact me any time and we can work out the details. |
… they are now in the README)
disabled source.attach plugin
original decompiler was not used
Ignore out outdated decompiler plugins (remains of older ECD versions)
use AST to remove block comments
increase with every usage
Merge this pull request to remove all code fragments which are not required to provide the great plugin functionality, but which trigger privacy concerns for many users.
Handles the problems disclosed by https://0x10f8.wordpress.com/2017/08/07/reverse-engineering-an-eclipse-plugin/