Skip to content

Commit

Permalink
Merge branch '__rultor'
Browse files Browse the repository at this point in the history
  • Loading branch information
rultor committed Apr 22, 2020
2 parents aa504c8 + ce8c53b commit ab8826a
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ and then:
```bash
$ java -jar jpeek-jar-with-dependencies.jar --sources . --target ./jpeek
```
<!--
@todo #452:30min Improve how to use section on README.md
How to Use section must be improved; we need to explain the many parameters
that jpeek jar accepts and the default values for each parameter.
-->

jPeek will analyze Java files in the current directory.
XML reports will be generated in the `./jpeek` directory. Enjoy.
Expand Down
12 changes: 12 additions & 0 deletions src/main/java/org/jpeek/App.java
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,10 @@ public App(final Path source, final Path target,
/**
* Analyze sources.
* @throws IOException If fails
* @todo #452:30min Extract report building
* Analyze method is too big. We need to extract report building from
* here and use a map instead of if statements se we can make
* easier to add and remove metrics from execution.
*/
@SuppressWarnings({
"PMD.ExcessiveMethodLength",
Expand Down Expand Up @@ -200,6 +204,14 @@ public void analyze() throws IOException {
)
);
}
if (this.params.containsKey("LCOM4")) {
reports.add(
new XslReport(
chain.transform(skeleton), xsl,
new ReportData("LCOM4", this.params, 0.5d, -0.1d)
)
);
}
if (this.params.containsKey("NHD")) {
reports.add(
new XslReport(
Expand Down

2 comments on commit ab8826a

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on ab8826a Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 452-fc6e85e0 discovered in README.md and submitted as #460. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on ab8826a Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 452-6485f2e2 discovered in src/main/java/org/jpeek/App.java and submitted as #461. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.