Skip to content

Commit

Permalink
Merge branch '__rultor'
Browse files Browse the repository at this point in the history
  • Loading branch information
@rultor
rultor committed Feb 26, 2018
2 parents fc4437f + 410f356 commit cc1a59b
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/test/java/org/jpeek/MetricsTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;

// @todo #18:30min Impediment: #103 must be fixed before LCOM5 is tested
// against: NoMethods, OneVoidMethodWithoutParams, WithoutAttributes,
// OneMethodCreatesLambda. The LCOM5 value for these will be "NaN".
// @todo #93:30min NHD needs to be tested against the following after #103 is
// fixed: NoMethods, OneVoidMethodWithoutParams, WithoutAttributes,
// OneMethodCreatesLambda. NHD score for all these is "NaN".
Expand Down Expand Up @@ -122,6 +119,10 @@ public static Collection<Object[]> targets() {
new Object[] {"MethodsWithDiffParamTypes", "LCOM5", 0.6667d},
new Object[] {"OverloadMethods", "LCOM5", 0.25d},
new Object[] {"TwoCommonAttributes", "LCOM5", 1.0d},
new Object[] {"NoMethods", "LCOM5", Double.NaN},
new Object[] {"WithoutAttributes", "LCOM5", Double.NaN},
new Object[] {"OneVoidMethodWithoutParams", "LCOM5", 1.0d},
new Object[] {"OneMethodCreatesLambda", "LCOM5", 1.5d},
new Object[] {"Bar", "NHD", 0.4d},
new Object[] {"Foo", "NHD", 0.3333d},
new Object[] {"MethodsWithDiffParamTypes", "NHD", 0.7143d},
Expand Down

1 comment on commit cc1a59b

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on cc1a59b Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 18-58649db9 disappeared from src/test/java/org/jpeek/MetricsTest.java, that's why I closed #124. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

Please sign in to comment.