-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of 'NaN' is incompatible with MetricsTest #103
Comments
Job #103 is now in scope, role is |
Bug was reported, see §29: +15 points just awarded to @llorllale/z, total is +240 |
Job #103 is already in scope |
@0crat refuse |
@skapral you technically lost your time here. I'm reassigning you back just as an exception. Please, keep in mind that 10 days means 10 days. The robot has no mercy) |
@yegor256 I know the rules, there is no need for mercy. BTW: once ago I had a proposal on the process just for the similar case: yegor256/datum#264. Anyway - PR is gone to upstream: are there any reason to keep this issue open? |
@skapral ask ticket reporter to close it, if you think it's done |
@llorllale? Could you please close the issue? |
thank you @skapral |
Job #103 is already in scope |
The job #103 is now out of scope |
@llorllale the only puzzle #181 is solved here. |
Following on from #102, and considering that it seems that we should implement all tests in
MetricsTest
(see #96 and this comment):The introduction of
NaN
as a value forclass/@value
is incompatible with the current implementation ofMetricsTest
. As far as I am aware, the only way to test forNaN
in an xpath predicate is by treating it as anxsd:string
, butMetricsTest
is expecting the value to be of typexsd:double
.Quickly changing
MetricsTest.value
to a String, enclosing the given values for other tests in quotes, and adapting the xpath accordingly leads to other errors, which suggests that a closer look needs to be taken.The text was updated successfully, but these errors were encountered: