Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of 'NaN' is incompatible with MetricsTest #103

Closed
llorllale opened this issue Jan 23, 2018 · 23 comments
Closed

Introduction of 'NaN' is incompatible with MetricsTest #103

llorllale opened this issue Jan 23, 2018 · 23 comments

Comments

@llorllale
Copy link
Contributor

Following on from #102, and considering that it seems that we should implement all tests in MetricsTest (see #96 and this comment):

The introduction of NaN as a value for class/@value is incompatible with the current implementation of MetricsTest. As far as I am aware, the only way to test for NaN in an xpath predicate is by treating it as an xsd:string, but MetricsTest is expecting the value to be of type xsd:double.

Quickly changing MetricsTest.value to a String, enclosing the given values for other tests in quotes, and adapting the xpath accordingly leads to other errors, which suggests that a closer look needs to be taken.

@0crat
Copy link
Collaborator

0crat commented Jan 23, 2018

@yegor256/z please, pay attention to this issue

@llorllale llorllale mentioned this issue Jan 23, 2018
@0crat 0crat removed their assignment Jan 23, 2018
@0crat
Copy link
Collaborator

0crat commented Jan 23, 2018

Job #103 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jan 23, 2018

Bug was reported, see §29: +15 points just awarded to @llorllale/z, total is +240

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2018

Job #103 is already in scope

@0crat
Copy link
Collaborator

0crat commented Feb 2, 2018

The job #103 assigned to @skapral/z. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@0crat
Copy link
Collaborator

0crat commented Feb 7, 2018

@skapral/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

skapral added a commit to skapral/jpeek that referenced this issue Feb 8, 2018
skapral added a commit to skapral/jpeek that referenced this issue Feb 8, 2018
skapral added a commit to skapral/jpeek that referenced this issue Feb 8, 2018
@0crat
Copy link
Collaborator

0crat commented Feb 10, 2018

@skapral/z this job was assigned to you 8 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0crat
Copy link
Collaborator

0crat commented Feb 12, 2018

The user @skapral/z resigned from #103, please stop working

@0crat
Copy link
Collaborator

0crat commented Feb 13, 2018

The job #103 assigned to @rok-povsic/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@rok-povsic
Copy link
Contributor

@yegor256 Please check if I should really have been assigned this issue, see here.

@yegor256
Copy link
Member

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Feb 14, 2018

@0crat refuse (here)

@yegor256 The user @rok-povsic/z resigned from #103, please stop working

@yegor256
Copy link
Member

@0crat assign @skapral

@yegor256
Copy link
Member

@skapral you technically lost your time here. I'm reassigning you back just as an exception. Please, keep in mind that 10 days means 10 days. The robot has no mercy)

@0crat
Copy link
Collaborator

0crat commented Feb 14, 2018

@0crat assign @skapral (here)

@yegor256 The job #103 assigned to @skapral/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.We should be aware that skapral is on vacation! This ticket may be delayed.

@0crat
Copy link
Collaborator

0crat commented Feb 14, 2018

Manual assignment of issues is discouraged, see §19: -5 points just awarded to @yegor256/z, total is +9659

@skapral
Copy link
Contributor

skapral commented Feb 15, 2018

@yegor256 I know the rules, there is no need for mercy. BTW: once ago I had a proposal on the process just for the similar case: yegor256/datum#264.

Anyway - PR is gone to upstream: are there any reason to keep this issue open?

@yegor256
Copy link
Member

@skapral ask ticket reporter to close it, if you think it's done

@skapral
Copy link
Contributor

skapral commented Feb 15, 2018

@llorllale? Could you please close the issue?

@llorllale
Copy link
Contributor Author

thank you @skapral

@0crat
Copy link
Collaborator

0crat commented Feb 15, 2018

Job #103 is already in scope

@0crat
Copy link
Collaborator

0crat commented Feb 15, 2018

@skapral/z resigned from #103, since the job is not in scope anymore

@0crat
Copy link
Collaborator

0crat commented Feb 15, 2018

The job #103 is now out of scope

@0pdd
Copy link
Collaborator

0pdd commented Jul 15, 2019

@llorllale the only puzzle #181 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants