Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#225) Added a matrix.xsd reference to matrix.xml #290

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

ilyakharlamov
Copy link
Contributor

@ilyakharlamov ilyakharlamov commented Jan 4, 2019

This PR (#225).

  • adds a new test case xmlHasSchema that checks whether the matrix.xml has a schema reference
  • implements adding of the schema reference to the matrix.xml
  • minor MatrixTest refactoring ("matrix.xml" is stored as a class constant now)

@0crat
Copy link
Collaborator

0crat commented Jan 4, 2019

@paulodamaso/z please, pay attention to this pull request

@0crat 0crat added the scope label Jan 4, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 4, 2019

Job #290 is now in scope, role is REV

@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #290 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #290      +/-   ##
============================================
+ Coverage     75.13%   75.25%   +0.11%     
- Complexity      178      179       +1     
============================================
  Files            33       33              
  Lines          1074     1079       +5     
  Branches         85       85              
============================================
+ Hits            807      812       +5     
  Misses          236      236              
  Partials         31       31
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/jpeek/Matrix.java 100% <100%> (ø) 11 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 522d54e...1062afb. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Jan 4, 2019

@paulodamaso/z everybody who has role REV is banned at #290; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

Copy link
Collaborator

@paulodamaso paulodamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyakharlamov Your PR looks good, let's just correct its description adding a reference to the issue resolved and a description of what have you done

@ilyakharlamov
Copy link
Contributor Author

@paulodamaso The description has been updated

@paulodamaso
Copy link
Collaborator

@ilyakharlamov Great, thanks!

@paulodamaso
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 4, 2019

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 1062afb into cqfn:master Jan 4, 2019
@rultor
Copy link
Collaborator

rultor commented Jan 4, 2019

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 15min)

@0crat 0crat removed the scope label Jan 4, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 4, 2019

Job gh:yegor256/jpeek#290 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Jan 4, 2019

The job #290 is now out of scope

@ilyakharlamov ilyakharlamov deleted the i225 branch January 5, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants