-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#225) Added a matrix.xsd reference to matrix.xml #290
Conversation
@paulodamaso/z please, pay attention to this pull request |
Job #290 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
============================================
+ Coverage 75.13% 75.25% +0.11%
- Complexity 178 179 +1
============================================
Files 33 33
Lines 1074 1079 +5
Branches 85 85
============================================
+ Hits 807 812 +5
Misses 236 236
Partials 31 31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilyakharlamov Your PR looks good, let's just correct its description adding a reference to the issue resolved and a description of what have you done
@paulodamaso The description has been updated |
@ilyakharlamov Great, thanks! |
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 15min) |
Job |
The job #290 is now out of scope |
This PR (#225).