Made XmlMethodCall public and added a test. #451
Conversation
|
This pull request #451 is assigned to @fanifieiev/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job |
| @@ -55,7 +52,7 @@ | |||
| @Override | |||
| public String asString() throws IOException { | |||
| return new Joined( | |||
| "", this.call.xpath("name/text()").get(0), | |||
| "", this.call.xpath("op/name/text()").get(0), | |||
There was a problem hiding this comment.
@vzurauskas Could you please replace get(0) with
org.cactoos.scalar.ItemAt ?
There was a problem hiding this comment.
@fanifieiev Can you explain why? If the goal is to get more object oriented by replacing method calls with object composition, this will not help, because ItemAt is a Scalar, and we would still need to call value() on it. This would only introduce an indirection without reducing the number of method calls.
| * Test case for {@link XmlMethodCall}. | ||
| * @since 0.44 | ||
| */ | ||
| final class XmlMethodCallTest { |
There was a problem hiding this comment.
@vzurauskas Why missing public keyword?
There was a problem hiding this comment.
@fanifieiev JUnit 5 test classes don't have to be public.
| final class XmlMethodCallTest { | ||
|
|
||
| @Test | ||
| void hasClassMethodAndArgs() throws IOException { |
There was a problem hiding this comment.
@vzurauskas Why missing public keyword?
There was a problem hiding this comment.
@fanifieiev JUnit 5 test classes don't have to be public.
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 15min) |
|
@fanifieiev/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please. |
|
@0crat status |
|
@paulodamaso This is what I know about this job in C7JGJ00DP, as in §32:
|
|
@0crat quality acceptable |
|
@0crat status |
|
@fanifieiev This is what I know about this job in C7JGJ00DP, as in §32:
|
|
@0crat out |
|
Code review was too long (8 days), architects (@paulodamaso) were penalized, see §55 |
|
@sereshqua/z please review this job completed by @fanifieiev/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
@fanifieiev please make sure your comments would mostly about design problems, not cosmetic issues during next CR |
@sereshqua OK |
|
@0crat quality acceptable |
PR for #443
I made the
XmlMethodCallpublic and added a test. N.B. The "call" elements in skeleton don't have the structure expected in the test, but it will be implemented in #437.